[Openmp-commits] [PATCH] D69857: [libomptarget] Replace INLINE with DEVICE to work around nvcc deleting forceinline symbols

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 5 16:18:38 PST 2019


JonChesterfield added a comment.

In D69857#1734826 <https://reviews.llvm.org/D69857#1734826>, @ABataev wrote:

> Bad decision. I would suggest to revert your pr3vious patches and restore intial code layout and then try step by step fixing it.


Well, we can't leave trunk broken. So sure, feel free to revert them.

However I cannot debug errors which only occur on other developers machines when using closed source compilers. So I can't fix it later either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69857/new/

https://reviews.llvm.org/D69857





More information about the Openmp-commits mailing list