[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: tools/archer/ompt-tsan.cpp:923-924
+
+  if (archer_flags->print_ompt_counters)
+    all_counter = new callback_counter_t[MAX_THREADS];
+
----------------
protze.joachim wrote:
> Hahnfeld wrote:
> > This functionality is not used in the tests and could be a separate patch.
> This functionality is useful for debugging errors resulting from errors in the OMPT implementation.
I agree, and this sounds like a good motivation for a second tool. What's the advantage of having this in `ompt-tsan.cpp`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890