[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jul 17 09:41:16 PDT 2019


protze.joachim marked 16 inline comments as done.
protze.joachim added inline comments.


================
Comment at: tools/archer/ftsan.c:2
+/*
+ * ftsan.c -- Archer runtime library, TSan annotations for Fortran
+ */
----------------
Hahnfeld wrote:
> protze.joachim wrote:
> > Hahnfeld wrote:
> > > Why do we need this in here? This should surely be handled in the compiler?
> > This allows to use those basic annotations of synchronization in Fortran code.
> > The annotation interface is also intended for manual instrumenting application code.
> > 
> > 
> > Like for SPEC OMP: 371.applu331/src/syncs.F90 
> > 
> > ```
> > @@ -82,6 +85,8 @@
> >  !$omp flush(isync)
> >           end do
> > +       CALL AnnotateHappensAfter(__FILE__, __LINE__, isync(omp_get_thread_num()))
> > +       CALL AnnotateHappensBefore(__FILE__, __LINE__, isync(iam))
> >           isync(iam) = 1
> >  !$omp flush(isync)
> >        endif
> > 
> > ```
> It's not required for Archer and belongs into the sanitizer runtime.
It doesn't harm to have this duplicately. I'm not sure how this would fit into the LLVM/sanitizer as long as there is no Fortran frontend supporting this sanitizer.

I moved the code to the other declarations in ompt-tsan.cpp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890





More information about the Openmp-commits mailing list