[Openmp-commits] [PATCH] D64808: [OPENMMP] Resolve lost LoopTripCnt for subsequent loops in same thread.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/test/offloading/looptripcnt.c:38
+  printf("num_threads %d num_teams %d\n", num_threads[0], num_teams[0]);
+// DEBUG: loop trip count is 128
+  return 0;
----------------
ronlieb wrote:
> ABataev wrote:
> > I think, instead of the debug messages better to check the results of the `printf`s.
> I initially thought about that, but I am worried that depending on what architecture you run on it might produce different numbers of teams, if the thread limit was a lot smaller than on a gpu for example.
> 
> but what I am really trying to test is that we found the loopTripCount to pass into the runtime.  
> 
> if you strongly prefer that I still do so, I will be happy to change the test. I would of course still keep the DP message for diagnostic purposes down the road.
It is always better to check the real results rather than debug messages. If you could write a test, which is able to provide a stable check, then do this.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64808/new/

https://reviews.llvm.org/D64808