[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: tools/archer/ftsan.c:2
+/*
+ * ftsan.c -- Archer runtime library, TSan annotations for Fortran
+ */
----------------
Hahnfeld wrote:
> Why do we need this in here? This should surely be handled in the compiler?
This allows to use those basic annotations of synchronization in Fortran code.
The annotation interface is also intended for manual instrumenting application code.


Like for SPEC OMP: 371.applu331/src/syncs.F90 

```
@@ -82,6 +85,8 @@
 !$omp flush(isync)
          end do
+       CALL AnnotateHappensAfter(__FILE__, __LINE__, isync(omp_get_thread_num()))
+       CALL AnnotateHappensBefore(__FILE__, __LINE__, isync(iam))
          isync(iam) = 1
 !$omp flush(isync)
       endif

```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890