[Openmp-commits] [PATCH] D59880: [OpenMP][WIP] RISCV64 port

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.
Herald added a subscriber: lenary.

Sorry for the delay...



================
Comment at: runtime/src/z_Linux_asm.S:1720-1722
+// #if OMPT_SUPPORT
+//   *exit_frame_ptr = 0;
+// #endif
----------------
I don't think we need this, it's now handled at all call-sites of `__kmp_invoke_microtask`. I'll post a patch to resolve any inconsistencies.

AFAICT removing this should reduce some of the (conditional) complexity of the stack layout.


================
Comment at: runtime/src/z_Linux_asm.S:1759-1760
+#else
+__gtid = 20
+__tid = 24
+#endif
----------------
I'd propose to make them negative, the implementation for `x86_64` does so as well.


================
Comment at: runtime/src/z_Linux_asm.S:1802-1805
+#if OMPT_SUPPORT
+	// Reserve 8 extra bytes for saving a5 register when OMPT is enabled
+	addi	t0, t0, 2
+#else
----------------
For example, this can go away.


================
Comment at: runtime/src/z_Linux_asm.S:1874-1878
+#if OMPT_SUPPORT
+	// Restore exit_frame address and clear exit_frame
+	ld	t0, -__exit_frame(fp)
+	sd	zero, 0(t0)
+#endif
----------------
Not needed, as said above.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59880/new/

https://reviews.llvm.org/D59880