[Openmp-commits] [PATCH] D64534: Remove OMP spec versioning

Fri Jul 12 04:25:50 PDT 2019

lebedev.ri added a comment.

In D64534#1582525 <https://reviews.llvm.org/D64534#1582525>, @Hahnfeld wrote:

> In D64534#1582505 <https://reviews.llvm.org/D64534#1582505>, @lebedev.ri wrote:
>
> > How does this play with `-fopenmp-version=` clang switches;
> >  This doesn't remove any public api, only makes all of it available "unconditionall", correct?
>
>
> AFAICT, yes.

Ok.

> Plus `-fopenmp-version` doesn't do much, I'm only aware of different treatment for one corner case in addition to changing the value of `_OPENMP`.

That does not sound right, it certainly results in different sema (see also: gcc9 force-bumping to openmp4),
and i sure hope it disables features that aren't in that spec version.

>> I think this is a good thing in the end, but this warrants a little
>>  bit more prominent announcement/RFC beforehand, on openmp-dev+llvm-dev.
> 
> There was a thread on openmp-dev: http://lists.llvm.org/pipermail/openmp-dev/2019-February/002356.html

Would be a great idea to at least bump it, with the link to the patch.

> I don't agree that this should be cross-posted to llvm-dev, everyone caring about OpenMP should be subscribed to openmp-dev.

> Furthermore, building the latest version was more or less the default, except you keep your CMake configuration over many years.

Yes

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64534/new/

https://reviews.llvm.org/D64534