[Openmp-commits] [PATCH] D64442: [OMPT] Cleanup reset of exit_frame pointer

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 9 12:28:03 PDT 2019


Hahnfeld created this revision.
Hahnfeld added reviewers: protze.joachim, hbae, AndreyChurbanov, jlpeyton.
Herald added subscribers: openmp-commits, kristof.beyls, javed.absar.
Herald added a project: OpenMP.

This is done at call-site and does not need to be handled in
__kmp_invoke_microtask. It was already absent from the x86
and x86_64 assembly, this patch removes it from the generic
implementation in z_Linux_util.cpp and adds documentation for
AArch64 and PPC64 that it's actually not needed. I can't test
on these architectures, so I don't want to change the code just
because it looks right :)

While at it, rename some variables for consistency and add a
check in test/ompt/parallel/normal.c to check that the pointer
was reset before entering the barrier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64442

Files:
  openmp/runtime/src/kmp_runtime.cpp
  openmp/runtime/src/z_Linux_asm.S
  openmp/runtime/src/z_Linux_util.cpp
  openmp/runtime/test/ompt/parallel/normal.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64442.208778.patch
Type: text/x-patch
Size: 10806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190709/ae81ad2e/attachment.bin>


More information about the Openmp-commits mailing list