[Openmp-commits] [PATCH] D64218: [OpenMP][NFCI] Cleanup the target synchronization implementation

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert created this revision.
jdoerfert added a reviewer: openmp-commits.
Herald added subscribers: bollu, mgorny.
Herald added a project: OpenMP.
jdoerfert retitled this revision from "[OpenMP][NFCI] Cleanup the target synchronization implementation

Note: WIP patch 2/3 to go with a RFC for the device RTL design (see D64217)" to "[OpenMP][NFCI] Cleanup the target synchronization implementation".
jdoerfert edited the summary of this revision.

Note: WIP patch 2/3 to go with a RFC for the device RTL design (see D64217 <https://reviews.llvm.org/D64217>)

  This NFCI patch includes the following cleanup steps:
    - Adjust the code according to the LLVM coding style, especially wrt.
      variable and method names.
    - Document the code with doxygen comments.
    - Change the comments to be less NVPTX specific.
    - Wrap CUDA specific calls into __kmpc_impl_XXX functions and define
      them in an own target_impl.h file.
    - Use a templated barrier implementation to remove code duplication.
    - Use a (macro) generator to reduce code duplication.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64218

Files:
  openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
  openmp/libomptarget/deviceRTLs/nvptx/src/sync.cpp
  openmp/libomptarget/deviceRTLs/nvptx/src/sync.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64218.208072.patch
Type: text/x-patch
Size: 13064 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190704/bf9ecd07/attachment-0001.bin>