[Openmp-commits] [PATCH] D64080: [OPENMP]Make __kmpc_push_tripcount thread safe.

Tue Jul 2 16:53:40 PDT 2019

hfinkel added subscribers: AndreyChurbanov, hfinkel.
hfinkel added a comment.

In D64080#1567348 <https://reviews.llvm.org/D64080#1567348>, @ABataev wrote:

> In D64080#1567327 <https://reviews.llvm.org/D64080#1567327>, @grokos wrote:
>
> > A long time ago we had identified the problem with the loop trip count and if I recall correctly the proposed solution was to store the trip count per OpenMP task. The fix would be implemented in libomp because libomptarget has no notion of tasks.
> >
> > @AlexEichenberger Can you confirm whether or not this is the case? I may confuse this with something else...
>
>
> The patch does exactly what you said: stores tripcount per task, but in the libomptarget, not libomp. When it will be implemented in libomp, we could remove this code. But we need fully functional implementation now, not in the future.

If this should really be fixed in libomp, then we should fix it there. At the very least, there should be a FIXME about removing the workaround once the libomp fix is in place. @AndreyChurbanov, any thoughts on this?

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64080/new/

https://reviews.llvm.org/D64080