[Openmp-commits] [PATCH] D71412: [libomptarget][nfc] Add declarations of atomic functions for amdgcn

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. See my comments below.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h:8
+//===----------------------------------------------------------------------===//
+
+#include "target_impl.h"
----------------
Header guards should be useful here.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h:34
+                                    unsigned long long compare,
+                                    unsigned long long val);
----------------
One could have opted for a template solution but this is fine too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71412/new/

https://reviews.llvm.org/D71412