[Openmp-commits] [PATCH] D71412: [libomptarget][nfc] Add declarations of atomic functions for amdgcn

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 12 04:54:38 PST 2019


JonChesterfield created this revision.
JonChesterfield added reviewers: jdoerfert, ABataev, grokos.
Herald added subscribers: openmp-commits, jfb, mgorny, jvesely.
Herald added a project: OpenMP.

[libomptarget][nfc] Add declarations of atomic functions for amdgcn

This enables building more source for amdgcn. The functions are usually available
in a hip runtime header, but are duplicated here to decouple the implementation


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71412

Files:
  openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
  openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h
  openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h


Index: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
===================================================================
--- openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
+++ openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
@@ -27,6 +27,8 @@
 #define SHARED __attribute__((shared))
 #define ALIGN(N) __attribute__((aligned(N)))
 
+#include "hip_atomics.h"
+
 ////////////////////////////////////////////////////////////////////////////////
 // Kernel options
 ////////////////////////////////////////////////////////////////////////////////
Index: openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h
===================================================================
--- /dev/null
+++ openmp/libomptarget/deviceRTLs/amdgcn/src/hip_atomics.h
@@ -0,0 +1,34 @@
+//===---- hip_atomics.h - Declarations of hip atomic functions ---- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "target_impl.h"
+
+DEVICE unsigned atomicAdd(unsigned *address, unsigned val);
+DEVICE int atomicAdd(int *address, int val);
+DEVICE unsigned long long atomicAdd(unsigned long long *address,
+                                    unsigned long long val);
+
+DEVICE unsigned atomicInc(unsigned *address);
+DEVICE unsigned atomicInc(unsigned *address, unsigned max);
+DEVICE int atomicInc(int *address);
+
+DEVICE int atomicMax(int *address, int val);
+DEVICE unsigned atomicMax(unsigned *address, unsigned val);
+DEVICE unsigned long long atomicMax(unsigned long long *address,
+                                    unsigned long long val);
+
+DEVICE int atomicExch(int *address, int val);
+DEVICE unsigned atomicExch(unsigned *address, unsigned val);
+DEVICE unsigned long long atomicExch(unsigned long long *address,
+                                     unsigned long long val);
+
+DEVICE unsigned atomicCAS(unsigned *address, unsigned compare, unsigned val);
+DEVICE int atomicCAS(int *address, int compare, int val);
+DEVICE unsigned long long atomicCAS(unsigned long long *address,
+                                    unsigned long long compare,
+                                    unsigned long long val);
Index: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
===================================================================
--- openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
+++ openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
@@ -60,6 +60,7 @@
 
 set(h_files
   ${CMAKE_CURRENT_SOURCE_DIR}/src/amdgcn_interface.h
+  ${CMAKE_CURRENT_SOURCE_DIR}/src/hip_atomics.h
   ${CMAKE_CURRENT_SOURCE_DIR}/src/target_impl.h
   ${devicertl_base_directory}/common/debug.h
   ${devicertl_base_directory}/common/device_environment.h


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71412.233582.patch
Type: text/x-patch
Size: 2921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20191212/ae894860/attachment.bin>


More information about the Openmp-commits mailing list