[Openmp-commits] [PATCH] D71382: [libomptarget] Move resource id functions into target specific code, implement for amdgcn

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked an inline comment as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/resource_id.hip:1
+//===--- resource_id.hip - AMDGCN OpenMP resource id functions --- HIP -*-===//
+//
----------------
ABataev wrote:
> We have target-specific files already, like `target_impl.h`, maybe just put all these stuff in this file?
target_impl is becoming a bit of a dumping ground, but sure - another four functions won't hurt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71382/new/

https://reviews.llvm.org/D71382