[Openmp-commits] [PATCH] D70395: [OpenMP] Implementation of OMPT reduction callbacks

Tue Dec 10 09:23:14 PST 2019

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Thx, looks much cleaner (IMHO) and good to me now.

In D70395#1776898 <https://reviews.llvm.org/D70395#1776898>, @protze.joachim wrote:

> In D70395#1764086 <https://reviews.llvm.org/D70395#1764086>, @jdoerfert wrote:
>
> > Yes. I was expecting functions but macros seems to be the solution used in this code so far.
>
>
> Macros are used, because variables are in the callers scope and re-used by the end macro.

I would have tried references/pointers but I guess macros are the state-of-the-art solution here.

> Probably a question of style: should there be a `do{}while(0)` to catch the `;`? 
>  We need the `;` after the macro invocation to please clang-format

Sure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70395/new/

https://reviews.llvm.org/D70395