[Openmp-commits] [PATCH] D70395: [OpenMP] Implementation of OMPT reduction callbacks

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

In D70395#1764086 <https://reviews.llvm.org/D70395#1764086>, @jdoerfert wrote:

> Yes. I was expecting functions but macros seems to be the solution used in this code so far.


Macros are used, because variables are in the callers scope and re-used by the end macro.

Probably a question of style: should there be a `do{}while(0)` to catch the `;`? 
We need the `;` after the macro invocation to please clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70395/new/

https://reviews.llvm.org/D70395