[Openmp-commits] [PATCH] D66846: [libomptarget] Refactor macros from omptarget-nvptx to inline functions

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 27 17:52:24 PDT 2019


JonChesterfield marked 2 inline comments as done.
JonChesterfield added a comment.

Will split as recommended



================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:78
+#if !defined(__clang__) || __clang_major__ >= 9
+#define __SYNCTHREADS() __syncthreads()
+#else
----------------
ABataev wrote:
> This is wrong, just call __syncthreads() here. 
Ouch. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66846/new/

https://reviews.llvm.org/D66846





More information about the Openmp-commits mailing list