[Openmp-commits] [PATCH] D65870: [OpenMP] Remove 'unnecessary parentheses'

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Aug 11 04:09:30 PDT 2019


Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:5708
 
     pteam = (kmp_team_t * (*))(&this_thr->th.th_team);
 
----------------
Hahnfeld wrote:
> AndreyChurbanov wrote:
> > I think these extra parentheses " (*)" can also be changed to "*".
> Yes, I'll update the patch as soon as I find time.
I've opted to just remove the cast altogether. (I'm not really sure why we need a pointer to `kmp_team_t *`here, but I guess there have been $reasons...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65870/new/

https://reviews.llvm.org/D65870





More information about the Openmp-commits mailing list