[Openmp-commits] [PATCH] D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In D65285#1613462 <https://reviews.llvm.org/D65285#1613462>, @Hahnfeld wrote:

> For the correct solution, could you point me to code that uses the `dll_path_ptr` member? Given that there were no problem with `static const char dll_path[PATH_MAX]` I guess it never assigns to `*dll_path_ptr`, but then I don't fully understand why it needs a pointer to a pointer...


I need to consult ittnotify developers to get exact answer, they are not available this week (vacation / sick leave). I'd guess the dll_path object is never used in reality, as you pointed out.  To me the type of dll_path_ptr should be "char*" instead of "const char**" in order to use memory occupied by dll_path array.  I'd wait till we know the details of the use / disuse of the dll_path_ptr before making final decision.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65285/new/

https://reviews.llvm.org/D65285