[Openmp-commits] [PATCH] D65870: [OpenMP] Remove 'unnecessary parentheses'

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld marked 2 inline comments as done.
Hahnfeld added inline comments.


================
Comment at: openmp/runtime/cmake/config-ix.cmake:55
 check_cxx_compiler_flag(-Wno-implicit-fallthrough LIBOMP_HAVE_WNO_IMPLICIT_FALLTHROUGH_FLAG)
-check_cxx_compiler_flag(-Wno-parentheses LIBOMP_HAVE_WNO_PARENTHESES_FLAG)
 check_cxx_compiler_flag(-Wno-strict-aliasing LIBOMP_HAVE_WNO_STRICT_ALIASING_FLAG)
----------------
jdoerfert wrote:
> Good (that we enable the warning), bad that there are so many disabled...
Please see the RFC on openmp-dev and D65867.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:5708
 
     pteam = (kmp_team_t * (*))(&this_thr->th.th_team);
 
----------------
AndreyChurbanov wrote:
> I think these extra parentheses " (*)" can also be changed to "*".
Yes, I'll update the patch as soon as I find time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65870/new/

https://reviews.llvm.org/D65870