[Openmp-commits] [PATCH] D60976: [OpenMP] Implement task modifier for reduction clause

[Hansang Bae via Phabricator via Openmp-commits]

hbae added a comment.

Just a few typos in the comment.



================
Comment at: runtime/src/kmp_tasking.cpp:2043
+/*!
+Internal struct for reduction data item related info set us by compiler.
+*/
----------------
set us by -> set up by


================
Comment at: runtime/src/kmp_tasking.cpp:2049
+  // three compiler-generated routines (init, fini are optional):
+  void *reduce_init; /**< data initialization routine (single paramemter) */
+  void *reduce_fini; /**< data finalization routine */
----------------
paramemter -> parameter


================
Comment at: runtime/src/kmp_tasking.cpp:2066
+  void *reduce_comb; /**< data combiner routine */
+  void *reduce_init; /**< data initialization routine (two paramemters) */
+  void *reduce_fini; /**< data finalization routine */
----------------
paramemters -> parameters


================
Comment at: runtime/src/kmp_tasking.cpp:2072
+/*!
+Internal struct for reduction data item related info set us by compiler.
+
----------------
set us by -> set up by


================
Comment at: runtime/src/kmp_tasking.cpp:2081
+  // three compiler-generated routines (init, fini are optional):
+  void *reduce_init; /**< data initialization routine (two paramemters) */
+  void *reduce_fini; /**< data finalization routine */
----------------
paramemters -> parameters


================
Comment at: runtime/src/kmp_tasking.cpp:2164
+      // objects will be lazily allocated/initialized if/when requested
+      // note than __kmp_allocate zeroes the allocated memory
       arr[i].reduce_priv = __kmp_allocate(nth * sizeof(void *));
----------------
note than -> note that


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60976/new/

https://reviews.llvm.org/D60976