[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled

Tue Apr 16 11:16:06 PDT 2019

AlexEichenberger added a comment.

response to Alexey's comment

================
Comment at: libomptarget/include/omptargetplugin.h:35
+// Initialize the requires flags for the device.
+void __tgt_rtl_init_requires(int64_t RequiresFlags);
+
----------------
ABataev wrote:
> Maybe it is better to make it target-independent rather than do this only for NVPTX target?
I thought about this too, but say for one device, there is only unified memory... so we would actually not care about the requires unified.

So it's probably more flexible to have it there, but I am not opposed to take a stricter approach "flag must be consistent regardless of implementation" 

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223