[Openmp-commits] [PATCH] D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.

Mon Apr 15 11:44:31 PDT 2019

Hahnfeld added a comment.

In D60578#1467071 <https://reviews.llvm.org/D60578#1467071>, @hfinkel wrote:

> In D60578#1466059 <https://reviews.llvm.org/D60578#1466059>, @Hahnfeld wrote:
>
> > In D60578#1465958 <https://reviews.llvm.org/D60578#1465958>, @hfinkel wrote:
> >
> > > > In that case these tests need to be marked `UNSUPPORTED` for versions of Clang that will not pass them. There's infrastructure for that, but it's not applied in the current form of this patch.
> > >
> > > Okay. This patch review is not the right place to discuss the libomptarget support for old Clang versions. We should have a separate thread on this subject.
> >
> >
> >
> >
> > > In any case, let's move forward with adding this test in that directory, and then we'll address the infrastructure issue as follow-up work.
> >
> > So put differently, you're proposing to land this in its current form (which will break for some users, including me) and wait for "somebody" to work on the infrastructure to fix things?
>
>
> Of course I'm not. I'm proposing that we put the test in the nvptx directory and then address the fact that it should apply to other offloading targets as follow up.

Okay, sorry for the wrong interpretation, I misread your last sentence.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60578/new/

https://reviews.llvm.org/D60578