[Openmp-commits] [PATCH] D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D60578#1464304 <https://reviews.llvm.org/D60578#1464304>, @hfinkel wrote:

> ...
>
> >> 
> >> 
> >>>> Why don't we have unit tests here or in the llvm-test suite?
> >>> 
> >>> Because this is the library. Do you have an idea how to write the unit tests for it? It can be tested only with the executable tests.
> >> 
> >> We write google unit tests for various components, maybe something like that works here as well. A test that makes sure the initial output of `omp_get_level` is now 1 would then be great. It is by far not trivial to determine that `omp_get_level`, if called with an uninitialized device RT, should return `parallelLevel + 1`.
> >> 
> >>> I know, that someone worked on the target-based testsuite, but don't know when it is going to be ready.
> >> 
> >> There is the V&V test suite: https://crpl.cis.udel.edu/ompvvsollve/
> >>  We could also add openmp target tests into the LLVM Test Suite and run them if people define CMAKE flags.
> > 
> > Actually, it was the testsuite, which reveals the problems with the runtime. But only after some changes in the compiler I made to run more constructs in SPMD. Before that they all were executed in non-SPMD and the problem was masked. And I don't see a problem here since the exhaustive testing is impossible in principle.
> >  If you have a testsuite and ready to prepare and send an RFC, solve the problems with the license, organize it, setup buildbots, provide support, then go ahead. We can do everything, but it requires a lot of time. I agree that we need target-specific testing.
>
> Our general policy is that all commits that can have tests, should have tests. We have OpenMP target tests in libomptarget/test -- and given that you've added tests there yourself, I assume that you know this ;) -- plus tests in libomptarget/deviceRTLs/nvptx/test - although it sounds like this situation can be triggered using portable code, so I'd prefer we add a test in libomptarget/test. Can you please do that?


Sure, if we have a testing infrastructure for this, I'll add the test. Just missed the tests for NVPTX, will definitely add it.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60578/new/

https://reviews.llvm.org/D60578