[Openmp-commits] [PATCH] D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D60578#1463545 <https://reviews.llvm.org/D60578#1463545>, @jdoerfert wrote:

> In D60578#1463461 <https://reviews.llvm.org/D60578#1463461>, @ABataev wrote:
>
> > In D60578#1463452 <https://reviews.llvm.org/D60578#1463452>, @jdoerfert wrote:
> >
> > > In D60578#1463411 <https://reviews.llvm.org/D60578#1463411>, @gtbercea wrote:
> > >
> > > > LGTM
> > >
> > >
> > > Is there a way we can test this?
> >
> >
> > It is tested in the internal testsuite, don't know when it is going to be committed to trunk
>
>
> There are two problems:
>
> 1. The internal testsuite did run before this patch, right? So it is unclear what that means.


No, the tests ran with this patch.

> 2. Changes done upstream might break this without us noticing for a while and without being able to know apriory.

We test everything before doing any changes.

> Why don't we have unit tests here or in the llvm-test suite?

Because this is the library. Do you have an idea how to write the unit tests for it? It can be tested only with the executable tests. I know, that someone worked on the target-based testsuite, but don't know when it is going to be ready.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60578/new/

https://reviews.llvm.org/D60578