[Openmp-commits] [PATCH] D59451: Fix gettid warnings and one test on FreeBSD

[Kamil Rytarowski via Phabricator via Openmp-commits]

krytarowski added inline comments.


================
Comment at: cmake/OpenMPTesting.cmake:129
+  if(${CMAKE_THREAD_LIBS_INIT} STREQUAL "-lpthread")
+    set(OPENMP_TEST_COMPILER_OPENMP_FLAGS "${OPENMP_TEST_COMPILER_OPENMP_FLAGS} -pthread")
+  else
----------------
At least in the past in CMake it was better to use list APPEND instead of 2x set for the same variable, because values could cache and not change as expected.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59451/new/

https://reviews.llvm.org/D59451