[Openmp-commits] [PATCH] D51107: [LIBOMPTARGET] Add support for mapping of lambda captures.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D51107#1225966, @grokos wrote:

> In https://reviews.llvm.org/D51107#1224877, @ABataev wrote:
>
> > In https://reviews.llvm.org/D51107#1224291, @Hahnfeld wrote:
> >
> > > I think it's more consistent to handle all data mapping in a single loop (in `target_data_begin`) as discussed before.
> >
> >
> > I think this is a different problem that should be solved separately. It requires a redesign of the existing solution, while I'm just trying to implement a new feature.
>
>
> I think I agree with Alexey here. I favor letting support for lambda captures in and later on we can redesign the way libomptarget handles mappings. Is there any objection?


I didn't ask to do the refactoring to land support for lambda captures. Instead I thought Alexey proposed allocating `firstprivate`s in `target_data_begin` and fully registering them with the mapping machinery. This should make `member_of` work without duplicating the code because the `firstprivate` "mapping" will be allocated when the loop reaches the depending entries. In `target` you'd only need to query all target pointers that need to be passed as a parameter to the kernel function.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51107