[Openmp-commits] [PATCH] D51107: [LIBOMPTARGET] Add support for mapping of lambda captures.

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

In https://reviews.llvm.org/D51107#1224877, @ABataev wrote:

> In https://reviews.llvm.org/D51107#1224291, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D51107#1223432, @ABataev wrote:
> >
> > > In https://reviews.llvm.org/D51107#1223428, @Hahnfeld wrote:
> > >
> > > > In https://reviews.llvm.org/D51107#1211075, @ABataev wrote:
> > > >
> > > > > BTW, the main problem here is that there is no mapping between host pointer and device pointer for the firstprivates, just like for the mapped data. We just need to rework the way we allocate the memory for the firstprivate to make `MEMBER_OF` to work.
> > > >
> > > >
> > > > I don't see this path taken in the latest patch. Is there a major drawback of doing this?
> > >
> > >
> > > I did it using new `tgtArgsPositions`, which handles mappings between the firstprivates and the corresponding target pointers.
> >
> >
> > I think it's more consistent to handle all data mapping in a single loop (in `target_data_begin`) as discussed before.
>
>
> I think this is a different problem that should be solved separately. It requires a redesign of the existing solution, while I'm just trying to implement a new feature.


I think I agree with Alexey here. I favor letting support for lambda captures in and later on we can redesign the way libomptarget handles mappings. Is there any objection?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51107