[Openmp-commits] [PATCH] D54967: [OPENMP][NVPTX]Basic support for reductions across the teams.

Alexey Bataev via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 27 14:50:14 PST 2018


ABataev marked an inline comment as done.
ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/reduction.cu:435
+EXTERN int32_t __kmpc_nvptx_teams_reduce_nowait_simple(kmp_Ident *loc,
+                                                       int32_t global_tid,
+                                                       kmp_CriticalName *crit) {
----------------
kkwli0 wrote:
> Why is `global_tid` being passed in but not used?
They are going to be used in future, at least in some diagnostics. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54967/new/

https://reviews.llvm.org/D54967





More information about the Openmp-commits mailing list