[Openmp-commits] [PATCH] D54960: [OpenMP][libomptarget] Refactor SPMD and runtime requirement checking

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/loop.cu:325
           lastiter, lb, ub, stride, chunk,
-          GetOmpThreadId(tid, isSPMDMode(), isRuntimeUninitialized()), tnum);
+          GetOmpThreadId(tid, isSPMDMode(),
+                         checkRuntimeUninitialized(loc)), tnum);
----------------
`checkSPMDMode(loc)`?


================
Comment at: libomptarget/deviceRTLs/nvptx/src/sync.cu:44
+EXTERN void __kmpc_barrier(kmp_Ident *loc_ref, int32_t tid) {
   if (isRuntimeUninitialized()) {
+    ASSERT0(LT_FUSSY, checkSPMDMode(loc_ref),
----------------
`checkRuntimeUninitialized(loc_ref)`?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54960/new/

https://reviews.llvm.org/D54960