[Openmp-commits] [PATCH] D40358: Use hyperbarrier by default on all architectures

[Paul Osmialowski via Phabricator via Openmp-commits]

pawosm01 added a comment.

I need to contact someone who introduced KMP_REVERSE_HYPER_BAR implementation (unfortunately, it was added here in a huge collective commit years ago, Tue Oct 7 16:25:50 2014).
I have a piece of proprietary code that stopped to fail on AArch64 after I reverted https://reviews.llvm.org/D40358. Digging deeper I found out that it's not the problem with hyperbariers per se. As I undefined KMP_REVERSE_HYPER_BAR, the problem went away. What else I found is that the problem can be reproduced on x86_64 too, only less frequent (once per ```for i in `seq 1 1000`; do``` execution). As I'd have to spend a time to figure out the logic behind it and verify its validity, in the meantime, can someone familiar with this code have a look at it and confirm reverse implementation is sane?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D40358