[Openmp-commits] [PATCH] D47131: [libomptarget-nvptx] loop: Determine if runtime uninitialized

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon May 21 02:42:56 PDT 2018


Hahnfeld created this revision.
Hahnfeld added reviewers: grokos, gtbercea.
Herald added a subscriber: openmp-commits.

The generic entry points for static loop scheduling previously
hardcoded that the runtime was initialized. This can be wrong if
the compiler analyzes that the runtime is not needed and calls
the init functions accordingly.

This didn't affect clang-ykt because they have entry points for
different combinations of SPMD x Runtime not needed. I didn't do
measurements yet but with inlining we might get away with always
calling the generic interface and letting compiler and runtime
figure out the rest.
In any case, a correct runtime is always better than having
functions that may only be called if previous calls passed in
a specific set of arguments!


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D47131

Files:
  libomptarget/deviceRTLs/nvptx/src/loop.cu

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47131.147747.patch
Type: text/x-patch
Size: 10352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180521/4527fd54/attachment-0001.bin>


More information about the Openmp-commits mailing list