[Openmp-commits] [PATCH] D48888: Removed "--no-as-needed" flag from OMPT tests to avoid failures on OSX

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D48888#1151198, @protze.joachim wrote:

> As discussed on the mailing list, the flag should only be dropped on Mac OS. My pragmatic solution would be:
>
>   if config.operating_system == 'Darwin':
>       config.substitutions.append(("--Wl,--no-as-needed", ""))
>
>
> Not sure what @Hahnfeld thinks about this solution :)
>
> The cleaner solution would probably be to define a %no-as-needed-flag substitution.


I'd prefer the second solution :D bonus points for a CMake check to see if the linker actually supports the flag. However, I'm not sure there is an OS except Darwin where the linker doesn't have that flag, so ...


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D48888