[Openmp-commits] [PATCH] D48888: Removed "--no-as-needed" flag from OMPT tests to avoid failures on OSX

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 3 12:47:34 PDT 2018


protze.joachim requested changes to this revision.
protze.joachim added a comment.
This revision now requires changes to proceed.

As discussed on the mailing list, the flag should only be dropped on Mac OS. My pragmatic solution would be:

  if config.operating_system == 'Darwin':
      config.substitutions.append(("--Wl,--no-as-needed", ""))

Not sure what @Hahnfeld thinks about this solution :)

The cleaner solution would probably be to define a %no-as-needed-flag substitution.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D48888





More information about the Openmp-commits mailing list