[Openmp-commits] [PATCH] D42427: Fix broken OpenMP runtime test cases for Windows

[Hans Wennborg via Phabricator via Openmp-commits]

hans added a comment.

This works for me if the NEEDS are replaced with REQUIRES.

ompt/misc/control_tool_no_ompt_support.c still fails though:

  FAIL: libomp :: ompt/misc/control_tool_no_ompt_support.c (66 of 161)
  ******************** TEST 'libomp :: ompt/misc/control_tool_no_ompt_support.c' FAILED ********************
  Script:
  --
  C:/src/llvm/build.release/./bin/clang.exe -fopenmp  -I C:/src/llvm/projects/openmp/runtime/test -I C:/src/llvm/build.release/projects/openmp/runtime/src -L C:/src/llvm/build.release/bin  C:\src\llvm\projects\openmp\runtime\test\ompt\misc\control_tool_no_ompt_support.c -o C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp && C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp
  --
  Exit Code: 1120
  
  Command Output (stdout):
  --
  $ "C:/src/llvm/build.release/./bin/clang.exe" "-fopenmp" "-I" "C:/src/llvm/projects/openmp/runtime/test" "-I" "C:/src/llvm/build.release/projects/openmp/runtime/src" "-L" "C:/src/llvm/build.release/bin" "C:\src\llvm\projects\openmp\runtime\test\ompt\misc\control_tool_no_ompt_support.c" "-o" "C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp"
  # command output:
  control_tool_no_ompt_support-faece2.o : error LNK2019: unresolved external symbol omp_control_tool referenced in function .omp_outlined.
  C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp : fatal error LNK1120: 1 unresolved externals
  
  # command stderr:
  clang.exe: error: linker command failed with exit code 1120 (use -v to see invocation)
  
  error: command failed with exit status: 1120
  
  --



================
Comment at: runtime/test/misc_bugs/omp_foreign_thread_team_reuse.c:2
 // RUN: %libomp-compile -lpthread && %libomp-run
+// NEEDS: pthread
+
----------------
NEEDS should be REQUIRES


https://reviews.llvm.org/D42427