[Openmp-commits] [PATCH] D42427: Fix broken OpenMP runtime test cases for Windows

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/src/dllexports:542
+%ifdef OMP_50
+    omp_control_tool                        891
+%endif # OMP_50
----------------
Hahnfeld wrote:
> hans wrote:
> > This one seems unrelated?
> No, it's need because all symbols not listed here are hidden when linking the OpenMP runtime library and will result in errors when compiling the test that uses the symbol.
This one is the reason why the `test/ompt/misc/control_tool_no_ompt_support.c` test case failed.
With OpenMP 5.0 this function is part of the interface. Even if the runtime is built without OMPT support, this function needs to be provided as a stub, returning a meaningful value.

I think, these lines should add the function to the exported symbols of the OpenMP dll.

If you build with LIBOMP_OMP_VERSION < 50, the test might still fail, because of the issue I fixed in D42432


https://reviews.llvm.org/D42427