[Openmp-commits] [PATCH] D55496: [OpenMP] RFC: fixes for LIBOMP_OMP_VERSION=4.5/4

Tue Dec 11 10:14:40 PST 2018

lebedev.ri added a comment.

In D55496#1327109 <https://reviews.llvm.org/D55496#1327109>, @AndreyChurbanov wrote:

> In D55496#1324768 <https://reviews.llvm.org/D55496#1324768>, @lebedev.ri wrote:
>
> > In D55496#1324745 <https://reviews.llvm.org/D55496#1324745>, @Hahnfeld wrote:
> >
> > > II think it would be best to just remove all the `#ifdef`s and code that is not needed anymore.
> >
> >
> > Sure, i could do that instead, if that is the final decision.
> >  I just don't want it to stay in the current sudo-broken state.
>
>
> I don't mind removing the OpenMP versioning from sources, but this is much bigger change which will be harder to review.

... and the one that would need an RFC i would imagine.

> Feel free to commit this for now, or work on the removing of all OpenMP versioning.

Ok, thank you for the review.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55496/new/

https://reviews.llvm.org/D55496