[Openmp-commits] [PATCH] D55496: [OpenMP] RFC: fixes for LIBOMP_OMP_VERSION=4.5/4

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Dec 11 08:48:16 PST 2018


AndreyChurbanov accepted this revision.
AndreyChurbanov added a comment.
This revision is now accepted and ready to land.

In D55496#1324768 <https://reviews.llvm.org/D55496#1324768>, @lebedev.ri wrote:

> In D55496#1324745 <https://reviews.llvm.org/D55496#1324745>, @Hahnfeld wrote:
>
> > II think it would be best to just remove all the `#ifdef`s and code that is not needed anymore.
>
>
> Sure, i could do that instead, if that is the final decision.
>  I just don't want it to stay in the current sudo-broken state.


I don't mind removing the OpenMP versioning from sources, but this is much bigger change which will be harder to review.
Feel free to commit this for now, or work on the removing of all OpenMP versioning.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55496/new/

https://reviews.llvm.org/D55496





More information about the Openmp-commits mailing list