[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang

Tue Apr 3 12:30:34 PDT 2018

Hahnfeld added a comment.

In https://reviews.llvm.org/D44992#1055893, @guansong wrote:

> I see. We compared the change in (4.0?) and after, realized the extern shared is turned off. We reenabled (basically allow it to pass parsing) and everything is expected.

This also was my original intention when implementing rdc, I just hadn't finished yet to write a patch for libomptarget.

> We noticed the change 751ae2ab8 also reenable this under a flag, with its comments for separate compilation units. Based on that, I think this is the right thing to do, although you mentioned cuda-rdc may have profound effects then what it has now.

Please do use SVN revisions which is still the canonical revision control system. For reference, this is https://reviews.llvm.org/rC325136.

> Thinking differently, nvcc allows extern shared, does that mean we should allow this without a special flag be used? Or have a dedicated flag, which means allow extern shared, to match nvcc's behavior for this kind of code?

No, I think Clang does the reasonable thing and emits an error for a declaration that is disallowed by the CUDA programming manual itself.

Repository:
  rOMP OpenMP

https://reviews.llvm.org/D44992