[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang

[Guansong Zhang via Phabricator via Openmp-commits]

guansong added a comment.

I see. We compared the change in (4.0?) and after, realized the extern shared is turned off. We reenabled (basically allow it to pass parsing) and everything is expected.

We noticed the change 751ae2ab8 also reenable this under a flag, with its comments for separate compilation units. Based on that, I think this is the right thing to do, although you mentioned cuda-rdc may have profound effects then what it has now.

Thinking differently, nvcc allows extern shared, does that mean we should allow this without a special flag be used? Or have a dedicated flag, which means allow extern shared, to match nvcc's behavior for this kind of code?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D44992