[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: runtime/src/ompt-internal.h:34
+
+typedef struct kmp_taskdata kmp_taskdata_t;
+
----------------
protze.joachim wrote:
> Hahnfeld wrote:
> > protze.joachim wrote:
> > > Hahnfeld wrote:
> > > > Why is this here?
> > > Below in line 47, this is used to store the pointer for the scheduling task, which is needed to return the frame information.
> > Sure, shouldn't this live in `kmp.h` is it's not already there?
> Do you suggest to move all ompt_*_info_t to kmp.h?
> 
> Or should I just move the include of ompt-internal.h after the forward declarations in kmp.h?
Ah, now I understand why you need this here, didn't get this before.

In this case, I'm fine with this (please add a comment that this file is included before the forward declarations) or you could replace the single use of `kmp_taskdata_t` with `struct kmp_taskdata`...


https://reviews.llvm.org/D38185