[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim marked 4 inline comments as done.
protze.joachim added inline comments.


================
Comment at: runtime/src/ompt-internal.h:34
+
+typedef struct kmp_taskdata kmp_taskdata_t;
+
----------------
Hahnfeld wrote:
> protze.joachim wrote:
> > Hahnfeld wrote:
> > > Why is this here?
> > Below in line 47, this is used to store the pointer for the scheduling task, which is needed to return the frame information.
> Sure, shouldn't this live in `kmp.h` is it's not already there?
Do you suggest to move all ompt_*_info_t to kmp.h?

Or should I just move the include of ompt-internal.h after the forward declarations in kmp.h?


https://reviews.llvm.org/D38185