[Openmp-commits] [PATCH] D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 27 06:44:40 PDT 2017


protze.joachim added inline comments.


================
Comment at: runtime/src/ompt-general.cpp:57-60
 typedef int (*ompt_initialize_t)(ompt_function_lookup_t lookup,
-                                 struct ompt_fns_t *fns);
+                                 ompt_data_t *tool_data);
 
+typedef void (*ompt_finalize_t)(ompt_data_t *tool_data);
----------------
Hahnfeld wrote:
> Why do we need these in here, they already live in `ompt.h`. I think this should be included...
They are not even used here. I removed them in the TR4 patch.


https://reviews.llvm.org/D39182





More information about the Openmp-commits mailing list