[Openmp-commits] [PATCH] D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

Looks good so far with one minor question.

I'll let this sit here until the TR4 changes are committed, in case someone else wants to comment.



================
Comment at: runtime/src/ompt-general.cpp:57-60
 typedef int (*ompt_initialize_t)(ompt_function_lookup_t lookup,
-                                 struct ompt_fns_t *fns);
+                                 ompt_data_t *tool_data);
 
+typedef void (*ompt_finalize_t)(ompt_data_t *tool_data);
----------------
Why do we need these in here, they already live in `ompt.h`. I think this should be included...


https://reviews.llvm.org/D39182