[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

Jonathan Peyton via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Oct 17 13:13:11 PDT 2017

jlpeyton added inline comments.

Comment at: runtime/src/kmp_ftn_os.h:54
+#define FTN_CONTROL_TOOL omp_control_tool
protze.joachim wrote:
> This is inconsistent with the ifs below: either OMPT_SUPPORT or OMP_50_ENABLED
> I would say OMP_50_ENABLED for the user facing functions. The implementation is a stub if OMPT_SUPPORT is off.
Yes, can you move this down below OMP_45_ENABLED and wrap it with the OMP_50_ENABLED guard.

Comment at: runtime/src/kmp_ftn_os.h:419-421
Same with this one.


More information about the Openmp-commits mailing list