[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/src/kmp_ftn_os.h:54
 
+#if OMPT_SUPPORT
+#define FTN_CONTROL_TOOL omp_control_tool
----------------
This is inconsistent with the ifs below: either OMPT_SUPPORT or OMP_50_ENABLED

I would say OMP_50_ENABLED for the user facing functions. The implementation is a stub if OMPT_SUPPORT is off.


https://reviews.llvm.org/D38185