[Openmp-commits] D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

[Wilmarth, Terry L via Openmp-commits]

KMP_ ?  :) 

-----Original Message-----
From: Narayanaswamy, Ravi 
Sent: Thursday, June 01, 2017 9:55 AM
To: reviews+D33227+public+e370644a3ef9e170 at reviews.llvm.org; Dmitriev, Serguei N <serguei.n.dmitriev at intel.com>; grokos at us.ibm.com; Hahnfeld at itc.rwth-aachen.de; Wilmarth, Terry L <terry.l.wilmarth at intel.com>
Cc: openmp-commits at lists.llvm.org; mgorny at gentoo.org; lildmh at gmail.com; acjacob at us.ibm.com; guansong.zhang at amd.com
Subject: RE: D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

Terry has brought up a good point.  We should reserve "OMP_" prefix for OpenMP lang defined environments
We should rename OMP_TARGET_OFFLOAD and OMP_TARGET_DEBUG.
We currently have a proposal from Terry : LIBOMPTARGET_xxx
Any other proposal, we can if necessary finalize in our bi-weekly meeting.


-----Original Message-----
From: Terry Wilmarth via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Wednesday, May 31, 2017 2:37 PM
To: Dmitriev, Serguei N <serguei.n.dmitriev at intel.com>; grokos at us.ibm.com; Hahnfeld at itc.rwth-aachen.de; Wilmarth, Terry L <terry.l.wilmarth at intel.com>; Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>
Cc: openmp-commits at lists.llvm.org; mgorny at gentoo.org; lildmh at gmail.com; acjacob at us.ibm.com; guansong.zhang at amd.com
Subject: [PATCH] D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

tlwilmar added a comment.

Hmmm... that's disturbing.

The policy for libomp is, if it's in the spec, it starts with OMP_, and if it's just in our implementation, it starts with KMP_. 
I guess this is not true for libomptarget.   I'd like to get Ravi's opinion on this, so don't make a change yet.


https://reviews.llvm.org/D33227