[Openmp-commits] [PATCH] D28599: kmp_affinity: Fix check if specific bit is set

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 12 03:11:56 PST 2017


Hahnfeld added a comment.

In https://reviews.llvm.org/D28599#643871, @jcownie wrote:

> Good point. My personal preference would be to use "== 0", rather than logical not, since I find that easier to read.
> So
>
>   if (((buf.edx >> 9) & 1) == 0) {
>       ...
>   }
>
>
> But your fix is fine too.


I agree, that looks easier to read. Will do the change on commit once approved.


https://reviews.llvm.org/D28599





More information about the Openmp-commits mailing list