[Openmp-commits] [PATCH] D28599: kmp_affinity: Fix check if specific bit is set

Jim Cownie via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 12 02:34:13 PST 2017


jcownie added a comment.

Good point. My personal preference would be to use "== 0", rather than logical not, since I find that easier to read.
So

  if (((buf.edx >> 9) & 1) == 0) {
      ...
  }

But your fix is fine too.


https://reviews.llvm.org/D28599





More information about the Openmp-commits mailing list