[Openmp-commits] [PATCH] D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases

[sunita chandrasekaran via Phabricator via Openmp-commits]

schandra added a comment.

In https://reviews.llvm.org/D34701#828682, @Hahnfeld wrote:

> In https://reviews.llvm.org/D34701#823166, @schandra wrote:
>
> > Hi Jonas
> >
> > Did you have further comments on this commit?
> >
> > Thanks 
> > Sunita
>
>
> Sorry that it's taken so long! Still not sure about the Fortran test as clang will currently not be able to handle this.
>
> Additionally, these tests currently won't pass because `omp_is_initial_device()` will return `1` when offloading to the host, correct? See https://reviews.llvm.org/D35719 why we had to disable libomptarget for 5.0.
>
> Find some more comments inline. In general, the tests should be brought to a consistent coding style (braces, end-comments, comment style and so on).


Great!! Thanks Jonas, we will fix these shortly. 
Sunita


https://reviews.llvm.org/D34701