[Openmp-commits] [PATCH] D26058: Add more conditions to check whether task waiting is necessary in kmp_omp_taskwait()

[Andrey Churbanov via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: runtime/src/kmp_tasking.c:1483
 
+        bool must_wait = ! taskdata->td_flags.team_serial && ! taskdata->td_flags.tasking_ser && ! taskdata->td_flags.final;
+
----------------
The check "! taskdata->td_flags.tasking_ser" looks redundant here, because this condition is effectively the same as "__kmp_tasking_mode != tskm_immediate_exec" that has already been checked above at the line 1446.

The check of the td_flags.final flag does make sense.


https://reviews.llvm.org/D26058